DaanHoogland commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r514205528



##########
File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java
##########
@@ -565,6 +564,18 @@ public boolean startKubernetesClusterOnCreate() {
         if (!isKubernetesClusterDashboardServiceRunning(true, 
startTimeoutTime)) {
             logTransitStateAndThrow(Level.ERROR, String.format("Failed to 
setup Kubernetes cluster : %s in usable state as unable to get Dashboard 
service running for the cluster", kubernetesCluster.getName()), 
kubernetesCluster.getId(),KubernetesCluster.Event.OperationFailed);
         }
+        retrieveScriptFiles();
+        for (int i = 0; i < clusterVMs.size(); ++i) {
+            try {
+                copyAutoscalerScripts(publicIpAddress, 
CLUSTER_NODES_DEFAULT_START_SSH_PORT + i);
+            } catch (Exception e) {
+                throw new CloudRuntimeException(e);
+            }
+        }
+        if (!createCloudStackSecret(keys)) {
+            logTransitStateAndThrow(Level.ERROR, String.format("Failed to 
setup keys for Kubernetes cluster %s",
+                kubernetesCluster.getName()), 
kubernetesCluster.getId(),KubernetesCluster.Event.OperationFailed);
+        }

Review comment:
       one or two extra methods




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to