harikrishna-patnala commented on a change in pull request #4447:
URL: https://github.com/apache/cloudstack/pull/4447#discussion_r518508407
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/XenServerGuru.java
##########
@@ -98,7 +98,12 @@ public VirtualMachineTO implement(VirtualMachineProfile vm) {
if (userVmVO != null) {
HostVO host = hostDao.findById(userVmVO.getHostId());
if (host != null) {
-
to.setVcpuMaxLimit(MaxNumberOfVCPUSPerVM.valueIn(host.getClusterId()));
+ // Max cpu cannot be more than host capability
+ if (host.getCpus() <
MaxNumberOfVCPUSPerVM.valueIn(host.getClusterId()))
+ to.setVcpuMaxLimit(host.getCpus());
Review comment:
I think host.getCpus() get the actual CPU on the physical host, but
xenserver host is capable of allocating virtual CPUs more than the actual count.
Here is the list of configuration limits for XS 7.1 version.
https://docs.citrix.com/en-us/xenserver/7-1/system-requirements/configuration-limits.html
It says "Virtual CPUs per VM (Linux)" 32. So we might need to set the value
according to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
