harikrishna-patnala commented on a change in pull request #4447:
URL: https://github.com/apache/cloudstack/pull/4447#discussion_r518524633
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/XenServerGuru.java
##########
@@ -98,7 +98,12 @@ public VirtualMachineTO implement(VirtualMachineProfile vm) {
if (userVmVO != null) {
HostVO host = hostDao.findById(userVmVO.getHostId());
if (host != null) {
-
to.setVcpuMaxLimit(MaxNumberOfVCPUSPerVM.valueIn(host.getClusterId()));
+ // Max cpu cannot be more than host capability
+ if (host.getCpus() <
MaxNumberOfVCPUSPerVM.valueIn(host.getClusterId()))
+ to.setVcpuMaxLimit(host.getCpus());
Review comment:
It might also depend on the supported limits on guest OS. but setting
the max vcpu limit less than or equal to host cpus does not give complete
leverage to scale the VM. Also this setting was there since long time so I
think this is something to do with OS type of XCP ng version limitation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
