Spaceman1984 commented on a change in pull request #4428:
URL: https://github.com/apache/cloudstack/pull/4428#discussion_r520396841
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
##########
@@ -128,9 +132,24 @@ protected EndPoint findEndPointInScope(Scope scope, String
sqlBase, Long poolId)
}
}
+ List<Long> dedicatedHosts = dedicatedResourceDao.listAllHosts();
Review comment:
Yes, I understand. Making this change is not going to reduce the size of
the result set, it will reduce the number of ids to order against. I don't
think adding this complexity is worth the effort as this functionality is not
available in the DAO, I will have to write a few more functions to make that
happen. If you feel that we need this, then I will go ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
