sureshanaparti commented on a change in pull request #4428:
URL: https://github.com/apache/cloudstack/pull/4428#discussion_r520429771
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
##########
@@ -128,9 +132,24 @@ protected EndPoint findEndPointInScope(Scope scope, String
sqlBase, Long poolId)
}
}
+ List<Long> dedicatedHosts = dedicatedResourceDao.listAllHosts();
Review comment:
@Spaceman1984 New method in dao would be better. Consider a case with 2
clusters, one has 'N' dedicated hosts and the other has None. When you process
the pool with second cluster, you have to iterate over the 'N' dedicated hosts
(belongs to first cluster) without any use go them. and also, you are passing
them to the sql knowingly that these host ids doesn't exist in the result set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
