Spaceman1984 commented on a change in pull request #4428:
URL: https://github.com/apache/cloudstack/pull/4428#discussion_r519712090
##########
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
##########
@@ -128,9 +132,24 @@ protected EndPoint findEndPointInScope(Scope scope, String
sqlBase, Long poolId)
}
}
+ List<Long> dedicatedHosts = dedicatedResourceDao.listAllHosts();
Review comment:
This call doesn't get all hosts, it gets all dedicated hosts, then
builds up a random list of dedicated hosts. To remove some of the entries I
will have to iterate through another list of hosts from another resultset which
I think would cause more overhead than doing it this way. Or am I
misunderstanding your intention?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
