sureshanaparti commented on a change in pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078#discussion_r524004638



##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -3237,13 +3245,29 @@ protected void runInContext() {
         }
     }
 
+    private void cleanupDownloadUrls(VMInstanceVO systemVm) {

Review comment:
       @ravening in case, any data is required for further processing in future 
in this method, the method definition/implementation can be updated based on 
the requirement in future. As the datacenter is only being used to cleanup the 
urls, so better use the datacenter id for the cleanup purpose here, and update 
the method name accordingly (suggestion below).
   
   ```suggestion
       private void cleanupDownloadUrlsInZone(long zoneId) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to