sureshanaparti commented on a change in pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078#discussion_r526027502



##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -3286,13 +3294,29 @@ protected void runInContext() {
         }
     }
 
+    private void cleanupDownloadUrls(VMInstanceVO systemVm) {
+        // clean download URLs when destroying ssvm
+        // clean only the volumes and templates of the zone
+        // to which ssvm belongs to
+        for (VolumeDataStoreVO volume 
:_volumeStoreDao.listVolumeDownloadUrlsByZoneId(systemVm.getDataCenterId())) {

Review comment:
       > then the entries will be cleared.
   
   ok @ravening, so all the zone url entries are deleted irrespective of the 
SSVM ip in the url, and a new url is generated whenever user/operator requests 
download. am i correct?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to