sureshanaparti commented on a change in pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078#discussion_r524145235
##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -3237,13 +3245,29 @@ protected void runInContext() {
}
}
+ private void cleanupDownloadUrls(VMInstanceVO systemVm) {
Review comment:
@ravening the download urls are related to zone, so I recommend to go
with zone id, which is relavent. Passing _systemVm_ (VMInstanceVO of SSVM) is
irrelevant here. Not sure what will be the future double work you are pointing
to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
