sureshanaparti commented on a change in pull request #4425:
URL: https://github.com/apache/cloudstack/pull/4425#discussion_r525902440



##########
File path: 
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -553,6 +553,22 @@ private void postCreateRecurringSnapshotForPolicy(long 
userId, long volumeId, lo
         }
     }
 
+    public void markRemovedSnapshot(long snapshotId) {

Review comment:
       _markRemovedSnapshot_ indicates the snapshot is already removed. I think 
_removeSnapshot_ (or _markSnapshotAsRemoved_) is ok. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to