sureshanaparti commented on a change in pull request #4425:
URL: https://github.com/apache/cloudstack/pull/4425#discussion_r525907352
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -587,6 +590,7 @@ protected Answer copySnapshot(DataObject srcData,
DataObject destData) {
if (cacheData != null) {
cacheMgr.deleteCacheObject(cacheData);
}
+ _snapshotService.markRemovedSnapshot(destData.getId());
Review comment:
Can you check for OperationTimedoutException (if thrown for timeout?),
set removed accordingly. Note that, the snapshot here is not in Error state as
the copy callback is not yet to be called, which takes the action based on the
operation failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
