weizhouapache commented on a change in pull request #4516:
URL: https://github.com/apache/cloudstack/pull/4516#discussion_r536536086
##########
File path:
plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
##########
@@ -132,7 +132,11 @@ public DataStore initialize(Map<String, Object> dsInfos) {
Long zoneId = (Long)dsInfos.get("zoneId");
String url = (String)dsInfos.get("url");
String providerName = (String)dsInfos.get("providerName");
- String hypervisorType = (String)dsInfos.get("hypervisorType");
+ Object hypervisorTypeObj = dsInfos.get("hypervisorType");
Review comment:
it would be better to define hypervisorType as
```
HypervisorType hypervisorType = (String)dsInfos.get("hypervisorType");
```
the other lines in this file needs to be changed accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
