DaanHoogland commented on a change in pull request #4516:
URL: https://github.com/apache/cloudstack/pull/4516#discussion_r541865261
##########
File path:
plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
##########
@@ -250,15 +249,15 @@ public DataStore initialize(Map<String, Object> dsInfos) {
parameters.setPath(hostPath.replaceFirst("/", ""));
parameters.setUserInfo(userInfo);
} else if (scheme.equalsIgnoreCase("PreSetup")) {
- if (StringUtils.isNotBlank(hypervisorType) &&
HypervisorType.getType(hypervisorType).equals(HypervisorType.VMware)) {
+ if (hypervisorType.equals(HypervisorType.VMware)) {
Review comment:
no, @alexandru-bagu , it is common practice using equals to call it on
the object guaranteed not to be null, in this case the enum member
```suggestion
if (HypervisorType.VMware.equals(hypervisorType)) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
