alexandru-bagu commented on a change in pull request #4516:
URL: https://github.com/apache/cloudstack/pull/4516#discussion_r541885686
##########
File path:
plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
##########
@@ -250,15 +249,15 @@ public DataStore initialize(Map<String, Object> dsInfos) {
parameters.setPath(hostPath.replaceFirst("/", ""));
parameters.setUserInfo(userInfo);
} else if (scheme.equalsIgnoreCase("PreSetup")) {
- if (StringUtils.isNotBlank(hypervisorType) &&
HypervisorType.getType(hypervisorType).equals(HypervisorType.VMware)) {
+ if (hypervisorType.equals(HypervisorType.VMware)) {
Review comment:
You misunderstand. If someone calls this function without providing this
parameter then they wouldn't know because there would be no error reported.
Alas I will commit your suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
