GabrielBrascher commented on a change in pull request #4548:
URL: https://github.com/apache/cloudstack/pull/4548#discussion_r544291460
##########
File path:
server/src/test/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImplTest.java
##########
@@ -368,6 +358,12 @@ public void importUnmanagedInstanceTest() {
when(importUnmanageInstanceCmd.getName()).thenReturn("TestInstance");
when(importUnmanageInstanceCmd.getAccountName()).thenReturn(null);
when(importUnmanageInstanceCmd.getDomainId()).thenReturn(null);
+ Map<String,Long> diskOfferings = new HashMap();
+ getDisks().forEach((disk) -> {
+ diskOfferings.put(disk.getDiskId(), 43L);
+ });
+ diskOfferings.remove("WrongRootDisk");
+
when(importUnmanageInstanceCmd.getDataDiskToDiskOfferingList()).thenReturn(diskOfferings);
Review comment:
I don't see how this test method is validating the PR.
I was expecting some sort of assertion or validation on the lists returned
to ensure that the implemented method is indeed returning the correct order?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
