DK101010 commented on a change in pull request #4548:
URL: https://github.com/apache/cloudstack/pull/4548#discussion_r544387659
##########
File path:
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
##########
@@ -1248,6 +1261,25 @@ public UserVmResponse
importUnmanagedInstance(ImportUnmanagedInstanceCmd cmd) {
return cmdList;
}
+ /**
+ * VCenter send a list of disk in lexicographical order, but not in every
+ * case is hard disk one the root disk. Therefore we must check if hd one
+ * the root disk and if not we search it and add it to the top of the
+ * list
Review comment:
Jepp, but on vmware side they are called hard disks. but i agree that
hard disk suggests otherwise
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]