DK101010 commented on a change in pull request #4548:
URL: https://github.com/apache/cloudstack/pull/4548#discussion_r545656572
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -7274,9 +7274,7 @@ public int compare(final UnmanagedInstanceTO.Disk disk1,
final UnmanagedInstance
}
int extractInt(UnmanagedInstanceTO.Disk disk) {
- String num = disk.getLabel().replaceAll("\\D", "");
- // return 0 if no digits found
- return num.isEmpty() ? 0 : Integer.parseInt(num);
+ return disk.getPosition() + (disk.getControllerUnit() *
100);
Review comment:
@shwstppr Good point, But how realistic is it to say that we have a
volume with a position and without a controller id.? I talked with my
administration and network colleagues and other controller types like NVME and
SATA have also a controller id.
Therefore I think about it to add an exception in the else condition? What
do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
