DK101010 commented on a change in pull request #4548:
URL: https://github.com/apache/cloudstack/pull/4548#discussion_r547113068
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -7274,9 +7274,7 @@ public int compare(final UnmanagedInstanceTO.Disk disk1,
final UnmanagedInstance
}
int extractInt(UnmanagedInstanceTO.Disk disk) {
- String num = disk.getLabel().replaceAll("\\D", "");
- // return 0 if no digits found
- return num.isEmpty() ? 0 : Integer.parseInt(num);
+ return disk.getPosition() + (disk.getControllerUnit() *
100);
Review comment:
@shwstppr Sure, we use also only IDE, SCSI controller but for me it
sounds critical in case of other/new controller to ingest vm's without volumes
. I think from user perspektive it is inconsistent to see that the vm is
ingested but is unusable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
