DK101010 commented on a change in pull request #4548:
URL: https://github.com/apache/cloudstack/pull/4548#discussion_r547247614
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -7239,7 +7239,9 @@ private static File fetchSystemVmKeyFile() {
instanceDisk.setController(DiskControllerType.getType(device.getClass().getSimpleName()).toString());
instanceDisk.setControllerUnit(((VirtualSCSIController) device).getBusNumber());
} else {
-
instanceDisk.setController(DiskControllerType.none.toString());
+ String msg = String.format("Controller of
disk %s is unsupported", instanceDisk.getLabel());
+ s_logger.error(msg);
+ throw new Exception(msg);
Review comment:
@shwstppr ahh sorry, I had not checked that you have already changed
the msg :D.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
