shwstppr commented on a change in pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#discussion_r563605527
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3844,7 +3848,10 @@ private UserVm createVirtualMachine(DataCenter zone,
ServiceOffering serviceOffe
// Check is hostName is RFC compliant
checkNameForRFCCompliance(hostName);
}
- instanceName = VirtualMachineName.getVmName(id, owner.getId(),
_instance);
+ instanceName = VirtualMachineName.getVmName(id, owner.getId(),
instanceSuffix);
Review comment:
@harikrishna-patnala default value of `instanceSuffix` is `_instance`
(which should get instance.name). Only in case of VMware and instanceFlag it is
set to hostname at ln 3832.
Therefore, only when instanceFlag and other conditions are satisfied
`instanceName` will be `i - <user_id> - <vm_id> -<hostName>` and will be later
set to hypervisor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
