harikrishna-patnala commented on a change in pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#discussion_r565031596



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4072,7 +4079,11 @@ public UserVmVO doInTransaction(TransactionStatus 
status) throws InsufficientCap
 
                 persistVMDeployAsIsProperties(vm, userVmOVFPropertiesMap);
 
-                _vmDao.saveDetails(vm);
+                List<String> hiddenDetails = new ArrayList<>();

Review comment:
       @shwstppr I think we can use a single line something like below to add 
display value.
           `super.addDetail(new UserVmDetailVO(resourceId, key, value, 
display))`
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to