shwstppr commented on a change in pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#discussion_r565053443
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4072,7 +4079,11 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
persistVMDeployAsIsProperties(vm, userVmOVFPropertiesMap);
- _vmDao.saveDetails(vm);
+ List<String> hiddenDetails = new ArrayList<>();
Review comment:
@harikrishna-patnala using addDetail method directly here still won't
make it single line as detail that will be added needs to be removed from
vm.details,
```
if (customParameters.containsKey(VmDetailConstants.NAME_ON_HYPERVISOR)) {
userVmDetailsDao.addDetail(vm.getId(),
VmDetailConstants.NAME_ON_HYPERVISOR,
customParameters.get(VmDetailConstants.NAME_ON_HYPERVISOR), false);
customParameters.remove(VmDetailConstants.NAME_ON_HYPERVISOR);
}
// then setting this trimmed customParameters in vm object
```
Current code may allow setting display=false for multiple details in future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
