This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit 25969078b5f1ef2942e9c00113c46e50b7fa08a5 Author: Gary D. Gregory <[email protected]> AuthorDate: Sun Feb 9 18:32:36 2025 -0500 Add Checkstyle UnnecessaryParentheses --- src/conf/checkstyle.xml | 1 + src/test/java/org/apache/commons/collections4/MapUtilsTest.java | 2 +- .../apache/commons/collections4/bloomfilter/LayeredBloomFilterTest.java | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml index cb6628fbd..74e94b2e2 100644 --- a/src/conf/checkstyle.xml +++ b/src/conf/checkstyle.xml @@ -91,6 +91,7 @@ limitations under the License. <module name="SuperFinalize" /> <module name="TypecastParenPad" /> <module name="UpperEll" /> + <module name="UnnecessaryParentheses" /> <module name="UnusedImports"/> <module name="WhitespaceAfter"/> <module name="WhitespaceAround"/> diff --git a/src/test/java/org/apache/commons/collections4/MapUtilsTest.java b/src/test/java/org/apache/commons/collections4/MapUtilsTest.java index 5a33af9ef..edb7d8dd7 100644 --- a/src/test/java/org/apache/commons/collections4/MapUtilsTest.java +++ b/src/test/java/org/apache/commons/collections4/MapUtilsTest.java @@ -416,7 +416,7 @@ public class MapUtilsTest { assertEquals(val, MapUtils.getByteValue(in, "key", val), 0); assertEquals(val, MapUtils.getByteValue(in, "key"), 0); assertEquals(val, MapUtils.getByteValue(in, "noKey", val), 0); - assertEquals(val, MapUtils.getByteValue(in, "noKey", key -> ((byte) 100)), 0); + assertEquals(val, MapUtils.getByteValue(in, "noKey", key -> (byte) 100), 0); assertEquals(0, MapUtils.getByteValue(in, "noKey"), 0); assertEquals(val, MapUtils.getByte(in, "key", val), 0); assertEquals(val, MapUtils.getByte(in, "noKey", val), 0); diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilterTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilterTest.java index 34eeab657..b5c5a2ee9 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilterTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/LayeredBloomFilterTest.java @@ -235,7 +235,7 @@ public class LayeredBloomFilterTest extends AbstractBloomFilterTest<LayeredBloom final LayerManager<NumberedBloomFilter> layerManager = LayerManager.<NumberedBloomFilter>builder() .setSupplier(() -> new NumberedBloomFilter(getTestShape(), 3, sequence[0]++)) .setExtendCheck(ExtendCheck.neverAdvance()) - .setCleanup(ll -> ll.removeIf(f -> (f.value-- == 0))).get(); + .setCleanup(ll -> ll.removeIf(f -> f.value-- == 0)).get(); final LayeredBloomFilter<NumberedBloomFilter> underTest = new LayeredBloomFilter<>(getTestShape(), layerManager); assertEquals(1, underTest.getDepth()); underTest.merge(TestingHashers.randomHasher());
