This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit e97ed28266faf2fa632e860db27bfe32168d4f1e Author: Gary D. Gregory <[email protected]> AuthorDate: Sun Feb 9 18:16:07 2025 -0500 Add Checkstyle EqualsHashCode --- src/conf/checkstyle.xml | 1 + src/test/java/org/apache/commons/collections4/ArrayUtilsTest.java | 6 ++++++ .../commons/collections4/comparators/ComparatorChainTest.java | 5 +++++ .../apache/commons/collections4/functors/EqualPredicateTest.java | 5 +++++ src/test/java/org/apache/commons/collections4/map/LRUMapTest.java | 6 ++++++ 5 files changed, 23 insertions(+) diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml index 0a9b54113..c5c63f7ac 100644 --- a/src/conf/checkstyle.xml +++ b/src/conf/checkstyle.xml @@ -56,6 +56,7 @@ limitations under the License. <module name="EmptyBlock"> <property name="option" value="text" /> </module> + <module name="EqualsHashCode" /> <module name="ExplicitInitialization" /> <module name="GenericWhitespace"/> <module name="IllegalImport"/> diff --git a/src/test/java/org/apache/commons/collections4/ArrayUtilsTest.java b/src/test/java/org/apache/commons/collections4/ArrayUtilsTest.java index 3d8668d9b..10f262037 100644 --- a/src/test/java/org/apache/commons/collections4/ArrayUtilsTest.java +++ b/src/test/java/org/apache/commons/collections4/ArrayUtilsTest.java @@ -44,6 +44,12 @@ public class ArrayUtilsTest { public boolean equals(final Object o) { return true; } + + @Override + public int hashCode() { + // Pairs with equals() + return super.hashCode(); + } } class LANG1261ChildObject extends LANG1261ParentObject { } diff --git a/src/test/java/org/apache/commons/collections4/comparators/ComparatorChainTest.java b/src/test/java/org/apache/commons/collections4/comparators/ComparatorChainTest.java index 5c700836f..bd00fcd6f 100644 --- a/src/test/java/org/apache/commons/collections4/comparators/ComparatorChainTest.java +++ b/src/test/java/org/apache/commons/collections4/comparators/ComparatorChainTest.java @@ -83,6 +83,11 @@ public class ComparatorChainTest extends AbstractComparatorTest<ComparatorChainT return getColumn(0) == row.getColumn(0) && getColumn(1) == row.getColumn(1) && getColumn(2) == row.getColumn(2); } + @Override + public int hashCode() { + return Arrays.hashCode(cols); + } + public int getColumn(final int colIndex) { return cols[colIndex]; } diff --git a/src/test/java/org/apache/commons/collections4/functors/EqualPredicateTest.java b/src/test/java/org/apache/commons/collections4/functors/EqualPredicateTest.java index bb9627bbc..9aa17fbe3 100644 --- a/src/test/java/org/apache/commons/collections4/functors/EqualPredicateTest.java +++ b/src/test/java/org/apache/commons/collections4/functors/EqualPredicateTest.java @@ -33,6 +33,11 @@ public class EqualPredicateTest extends AbstractPredicateTest { public boolean equals(final Object obj) { return b; } + + @Override + public int hashCode() { + return Boolean.hashCode(b); + } } private static final EqualsTestObject FALSE_OBJECT = new EqualsTestObject(false); diff --git a/src/test/java/org/apache/commons/collections4/map/LRUMapTest.java b/src/test/java/org/apache/commons/collections4/map/LRUMapTest.java index 400ae3317..a5c1e4605 100644 --- a/src/test/java/org/apache/commons/collections4/map/LRUMapTest.java +++ b/src/test/java/org/apache/commons/collections4/map/LRUMapTest.java @@ -115,6 +115,12 @@ public class LRUMapTest<K, V> extends AbstractOrderedMapTest<K, V> { this.code = code; } + @Override + public boolean equals(Object o) { + // Pairs with equals() + return super.equals(o); + } + @Override public int hashCode() { // always return the same hash code
