This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit 8e408017aef3894d15d535dbd17d5f49c07e34b0 Author: Gary D. Gregory <[email protected]> AuthorDate: Sun Feb 9 18:07:17 2025 -0500 Add Checkstyle DefaultComesLast --- src/conf/checkstyle.xml | 1 + src/main/java/org/apache/commons/collections4/map/Flat3Map.java | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml index 197809dc2..238381046 100644 --- a/src/conf/checkstyle.xml +++ b/src/conf/checkstyle.xml @@ -52,6 +52,7 @@ limitations under the License. <module name="ArrayTypeStyle" /> <module name="AvoidStarImport"/> <module name="CovariantEquals" /> + <module name="DefaultComesLast" /> <module name="ExplicitInitializationCheck" /> <module name="GenericWhitespace"/> <module name="IllegalImport"/> diff --git a/src/main/java/org/apache/commons/collections4/map/Flat3Map.java b/src/main/java/org/apache/commons/collections4/map/Flat3Map.java index ec304b698..334682cac 100644 --- a/src/main/java/org/apache/commons/collections4/map/Flat3Map.java +++ b/src/main/java/org/apache/commons/collections4/map/Flat3Map.java @@ -980,10 +980,6 @@ public class Flat3Map<K, V> implements IterableMap<K, V>, Serializable, Cloneabl // add new mapping switch (size) { - default: - convertToMap(); - delegateMap.put(key, value); - return null; case 2: hash3 = key == null ? 0 : key.hashCode(); key3 = key; @@ -999,6 +995,10 @@ public class Flat3Map<K, V> implements IterableMap<K, V>, Serializable, Cloneabl key1 = key; value1 = value; break; + default: + convertToMap(); + delegateMap.put(key, value); + return null; } size++; return null;
