knight9999 commented on a change in pull request #785: refactor: deprecate
mediaPlaybackAllowsAirPlay
URL: https://github.com/apache/cordova-ios/pull/785#discussion_r379717700
##########
File path:
CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
##########
@@ -74,9 +74,25 @@ - (WKWebViewConfiguration*)
createConfigurationFromSettings:(NSDictionary*)setti
}
configuration.allowsInlineMediaPlayback = [settings
cordovaBoolSettingForKey:@"AllowInlineMediaPlayback" defaultValue:NO];
- configuration.mediaPlaybackRequiresUserAction = [settings
cordovaBoolSettingForKey:@"MediaPlaybackRequiresUserAction" defaultValue:YES];
+
+ // Check for usage of the older preference key, alert, and use.
+ BOOL mediaTypesRequiringUserActionForPlayback = [settings
cordovaBoolSettingForKey:@"MediaTypesRequiringUserActionForPlayback"
defaultValue:YES];
+ NSString *mediaPlaybackRequiresUserActionKey = [settings
cordovaSettingForKey:@"MediaPlaybackRequiresUserAction"];
+ if(mediaPlaybackRequiresUserActionKey != nil) {
+ mediaTypesRequiringUserActionForPlayback = [settings
cordovaBoolSettingForKey:@"MediaPlaybackRequiresUserAction" defaultValue:YES];
+ }
+ configuration.mediaTypesRequiringUserActionForPlayback =
mediaTypesRequiringUserActionForPlayback;
+
Review comment:
These codes are for `mediaTypeRequiringUserActionForPlayback` which
(already) included in other PR https://github.com/apache/cordova-ios/pull/784.
Is this necessary for `allowsAirPlayForMediaPlayback` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
