dpogue commented on a change in pull request #785: refactor: deprecate
mediaPlaybackAllowsAirPlay
URL: https://github.com/apache/cordova-ios/pull/785#discussion_r379724901
##########
File path: bin/templates/project/__PROJECT_NAME__/config.xml
##########
@@ -53,7 +53,7 @@
<preference name="DisallowOverscroll" value="false" />
<preference name="EnableViewportScale" value="false" />
<preference name="KeyboardDisplayRequiresUserAction" value="true" />
- <preference name="MediaPlaybackRequiresUserAction" value="false" />
+ <preference name="MediaTypesRequiringUserActionForPlayback" value="false"
/>
Review comment:
@erisu FYI, `value="false"` will not work the way you think it will 🙃
Essentially, `cordovaBoolSettingForKey` expects the value to be a 0 or 1,
and turns any other non-zero value truthy. I kinda consider this to be a bug in
`cordovaBoolSettingForKey` tbh.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
