erisu commented on a change in pull request #785: refactor: deprecate 
mediaPlaybackAllowsAirPlay
URL: https://github.com/apache/cordova-ios/pull/785#discussion_r379989880
 
 

 ##########
 File path: bin/templates/project/__PROJECT_NAME__/config.xml
 ##########
 @@ -53,7 +53,7 @@
     <preference name="DisallowOverscroll" value="false" />
     <preference name="EnableViewportScale" value="false" />
     <preference name="KeyboardDisplayRequiresUserAction" value="true" />
-    <preference name="MediaPlaybackRequiresUserAction" value="false" />
+    <preference name="MediaTypesRequiringUserActionForPlayback" value="false" 
/>
 
 Review comment:
   Thank you for bringing this up.
   
   I will take a look at how to improve and fix this behavior so it works the 
way we expect.
   
   Since my changes are just updating the preference name, for the most part, 
and that the behavior you are bringing up is applied to all boolean 
preferences, I will handle it in a separate PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to