kezhuw commented on code in PR #454:
URL: https://github.com/apache/curator/pull/454#discussion_r1156186438
##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java:
##########
@@ -797,7 +797,7 @@ public void performBackgroundOperation(OperationAndData<T>
dummy) throws Excepti
{
if (
!client.getZookeeperClient().getRetryPolicy().allowRetry(e) )
{
- final CuratorEvent event = makeCuratorEvent(client,
e.code().intValue(), e.getPath(), null, e.getPath(), null);
Review Comment:
I overlooked the callback case in reviewing #453, `CuratorEvent::getName` is
useless in reconstruction of `KeeperException`. But in callback, it should be
`null` as no node is created. This is also consistent with ZooKeeper world's
callback. This is currently pushed as hotfix commit. I think it might not worth
to create separated pr for this. Any thoughts ? @tisonkun @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
