kezhuw commented on code in PR #454:
URL: https://github.com/apache/curator/pull/454#discussion_r1157373937


##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java:
##########
@@ -797,7 +797,7 @@ public void performBackgroundOperation(OperationAndData<T> 
dummy) throws Excepti
                 {
                     if ( 
!client.getZookeeperClient().getRetryPolicy().allowRetry(e) )
                     {
-                        final CuratorEvent event = makeCuratorEvent(client, 
e.code().intValue(), e.getPath(), null, e.getPath(), null);

Review Comment:
   @tisonkun You are right. I have reverted such a change to keep it as is. The 
change will break `TestLeaderAcls::testAclErrorWithLeader` which depends on 
this un-handled behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to