kezhuw commented on code in PR #454:
URL: https://github.com/apache/curator/pull/454#discussion_r1157286371
##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java:
##########
@@ -900,8 +900,6 @@ private void sendBackgroundResponse(int rc, String path,
Object ctx, String name
private static CuratorEvent makeCuratorEvent(CuratorFrameworkImpl client,
int rc, String path, Object ctx, String name, Stat stat)
{
Review Comment:
I have introduced a static version of `sendBackgroundResponse`, so that all
response are go through this method finally. I saw no "beauty" code path to
construct `CuratorEvent`, too many parameters ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
