stevedlawrence commented on a change in pull request #326: Daffodil 2280
cleanup - removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393740586
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala
##########
@@ -110,9 +110,12 @@ abstract class ChoiceTermBase(
with ChoiceAGMixin
with HasOptRepTypeMixinImpl {
- requiredEvaluations(branchesAreNonOptional)
- requiredEvaluations(branchesAreNotIVCElements)
- requiredEvaluations(modelGroupRuntimeData.preSerialization)
+ override protected def check() {
+ super.check()
+ requiredEvaluations(branchesAreNonOptional)
+ requiredEvaluations(branchesAreNotIVCElements)
+ requiredEvaluations(modelGroupRuntimeData.preSerialization)
+ }
Review comment:
Makes a lot of sense. Definitely needs some documntation. Thoughts on
renaming the "check" function to something like ``registerAsActive`` to make it
more clear what the purpose of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
