stevedlawrence commented on a change in pull request #326: Daffodil 2280
cleanup - removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393659841
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ParticleMixin.scala
##########
@@ -96,7 +96,11 @@ trait RequiredOptionalMixin { self: ElementBase =>
// Treat all arrays as non-required so that we can tolerate invalid
// infosets where the number of events is fewer than the array minimum
occurrences.
else if (isArray) false
- else false
+ else if (minOccurs == 0 && maxOccurs == 0) false
Review comment:
Is this even possible? I though maxOccurs always had to be greater than 1?
There's more logic below for maxOccurs == 0, so maybe I'm wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
