stevedlawrence commented on a change in pull request #326: Daffodil 2280
cleanup - removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393652312
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala
##########
@@ -246,7 +254,7 @@ abstract class ModelGroup(index: Int)
*/
lazy val potentialLastChildren: (Seq[Term], Boolean) = {
val (potentialLast, allOptional) = this match {
- case ch: ChoiceTermBase => (ch.groupMembers, false)
+ case ch: ChoiceTermBase => (ch.groupMembers, false) // TBD: Why false?
case sq: SequenceTermBase if !sq.isOrdered => (sq.groupMembers, true) //
TBD: is true correct? Are all children optional in unordered sequence?
Review comment:
Is this TBD determined? There's also one below on the next line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
