stevedlawrence commented on a change in pull request #343: Daffodil 2302 fixes
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r401576473
##########
File path: build.sbt
##########
@@ -113,7 +113,11 @@ lazy val commonSettings = Seq(
"-language:experimental.macros",
"-unchecked",
"-Xfatal-warnings",
- "-Xxml:-coalescing",
+ "-Xxml:-coalescing"
+ ),
+ javacOptions ++= Seq(
+ "-Werror",
+ "-Xlint:deprecation"
),
Review comment:
I noticed an issue when running ``sbt universal:packageBin``. This command
calls ``sbt doc`` for all subprojects. In particular, it calls ``sbt
daffodil-udf/doc``. It looks like because there is Java code in this repo is
calls javadoc, and these javacOptions get passed to it. But these aren't valid
options for javadoc, only for javac. There's an sbt issue talking about this
behavior: https://github.com/sbt/sbt/issues/355
Looks like the solution is to do ``javacOptions in Compile in compile ++=
...``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
