mbeckerle commented on a change in pull request #343: Daffodil 2302 fixes 
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r401577672
 
 

 ##########
 File path: daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/Daffodil.scala
 ##########
 @@ -200,9 +220,10 @@ class Compiler private[sapi] () {
    *                   then no namespace is used. With not preceded by 
"{namespace}",
    *                   then Daffodil will figure out the namespace.
    */
+  @deprecated("Use DataProcessor.setExternalVariables", "2.6.0")
   def setExternalDFDLVariables(extVarsMap: Map[String, String]): Unit = {
 
 Review comment:
   Probably bug in scaladoc. There are multiple overloads of this method name, 
and they even have the same number of arguments, same return tyhpe. Only the 
arg type is different. Easy to imagine a bug there. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to