stevedlawrence commented on a change in pull request #343: Daffodil 2302 fixes 
external variables API difficulties
URL: https://github.com/apache/incubator-daffodil/pull/343#discussion_r401583739
 
 

 ##########
 File path: daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/Daffodil.scala
 ##########
 @@ -458,13 +582,29 @@ class DataProcessor private[sapi] (dp: SDataProcessor)
    *                then no namespace is used. If not preceded by anything,
    *                then Daffodil will figure out the namespace.
    */
-  def setExternalVariables(extVars: Map[String, String]) = 
dp.setExternalVariables(extVars)
+  def setExternalVariables(extVars: Map[String, String]) =
 
 Review comment:
   Ah, I think this is the one I was seeing not being deprecated. I tihnk I was 
just confused before. This is the only one that's missing an @deprecated 
annotation. Everything else looks good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to