stevedlawrence commented on a change in pull request #452: URL: https://github.com/apache/incubator-daffodil/pull/452#discussion_r532894014
########## File path: daffodil-schematron/src/main/resources/iso-schematron-xslt2/ExtractSchFromRNG-2.xsl ########## @@ -0,0 +1,128 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<!-- + Stylesheet for extracting Schematron information from a RELAX-NG schema. + Based on the stylesheet for extracting Schematron information from W3C XML Schema. + + For usage details, see http://www.topologi.com/resources/schtrn_xsd_paper.html + + Created by Eddie Robertsson 2002/06/01 + Update for ISO Schematron using XSLT2 Rick Jelliffe 2010-04-14 + MIT licensed 2010-07-10 +--> + Review comment: Looks like this and other xsl files are licensed as both MIT and Apache? I'm not sure if that's correct. Did you add the Apache license or did you get it from Apache Camel like that? If this is actually MIT licensed and the Apache header was incorrectly added, because we're including this in source, we must also update the root LICENSE file to include the MIT license and a listing of these files that are MIT licensed (see the "subcomponent" stuff near the end. We must also add a LICENSE file, similar to the root one but with only the stuff specific to daffodil-schematron to ``daffodil-schematron/src/main/resrouces/METAINF/{LICENSE,NOTICE}. This license/notice is included in the compiled jar and so is specific to it. We must also update the daffodil-cli/bin.LICENSE and daffodil-cli/bin.NOTICE files if the daffodil-schematron jar (and it's dependencies) will will be bundled in that CLI zip/tar/rpm/msi. I think you also mentioned some of this came from Apache Camel? If so, we need to add the camel NOTICE information to the root NOTICE file, and the NOTICE file in ``daffodil-schemtron/src/main/resources/METAINF/NOTICE``. But it feels like maybe Apache Camel did not do the licesning correctly? We can't simply add an Apache license to something that is already MIT licensed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
