jw3 commented on a change in pull request #452: URL: https://github.com/apache/incubator-daffodil/pull/452#discussion_r533322810
########## File path: daffodil-schematron/src/main/resources/iso-schematron-xslt2/ExtractSchFromRNG-2.xsl ########## @@ -0,0 +1,128 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<!-- + Stylesheet for extracting Schematron information from a RELAX-NG schema. + Based on the stylesheet for extracting Schematron information from W3C XML Schema. + + For usage details, see http://www.topologi.com/resources/schtrn_xsd_paper.html + + Created by Eddie Robertsson 2002/06/01 + Update for ISO Schematron using XSLT2 Rick Jelliffe 2010-04-14 + MIT licensed 2010-07-10 +--> + Review comment: > Did you add the Apache license or did you get it from Apache Camel like that? It does look like the Camel project adds the Apache header. I had only compared the manifest from Camel with the ISO Schematron 2 distribution, not the file contents. The best way from here is to replace all of these with the files from the official distribution, which only have the MIT header. The Extract* files are a special case, not part of the distribution. Will dig deeper for authoritative source on those, I see a couple different versions floating around. Ill pull those out and put in the next PR, which makes more sense anyways. > I think you also mentioned some of this came from Apache Camel? The resources came from over there, but are going to be replaced with the standard distribution, nothing else remains a direct use. Overall I used their approach to guide the Scala implementation so wanted to give credit in readme, but everything was converted from Java to Scala and structurally changed. ### todo - [x] remove the Extract resources - [ ] replace other resources with ISO Sch distribution - [ ] move to schematron package I can address this later today ########## File path: daffodil-schematron/src/main/resources/iso-schematron-xslt2/ExtractSchFromRNG-2.xsl ########## @@ -0,0 +1,128 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<!-- + Stylesheet for extracting Schematron information from a RELAX-NG schema. + Based on the stylesheet for extracting Schematron information from W3C XML Schema. + + For usage details, see http://www.topologi.com/resources/schtrn_xsd_paper.html + + Created by Eddie Robertsson 2002/06/01 + Update for ISO Schematron using XSLT2 Rick Jelliffe 2010-04-14 + MIT licensed 2010-07-10 +--> + Review comment: > Did you add the Apache license or did you get it from Apache Camel like that? It does look like the Camel project adds the Apache header. I had only compared the manifest from Camel with the ISO Schematron 2 distribution, not the file contents. The best way from here is to replace all of these with the files from the official distribution, which only have the MIT header. The Extract* files are a special case, not part of the distribution. Will dig deeper for authoritative source on those, I see a couple different versions floating around. Ill pull those out and put in the next PR, which makes more sense anyways. > I think you also mentioned some of this came from Apache Camel? The resources came from over there, but are going to be replaced with the standard distribution, nothing else remains a direct use. Overall I used their approach to guide the Scala implementation so wanted to give credit in readme, but everything was converted from Java to Scala and structurally changed. ### todo - [x] remove the Extract resources - [ ] replace other resources with ISO Sch distribution - [x] move to schematron package I can address this later today ########## File path: daffodil-schematron/src/main/resources/iso-schematron-xslt2/ExtractSchFromRNG-2.xsl ########## @@ -0,0 +1,128 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<!-- + Stylesheet for extracting Schematron information from a RELAX-NG schema. + Based on the stylesheet for extracting Schematron information from W3C XML Schema. + + For usage details, see http://www.topologi.com/resources/schtrn_xsd_paper.html + + Created by Eddie Robertsson 2002/06/01 + Update for ISO Schematron using XSLT2 Rick Jelliffe 2010-04-14 + MIT licensed 2010-07-10 +--> + Review comment: > Did you add the Apache license or did you get it from Apache Camel like that? It does look like the Camel project adds the Apache header. I had only compared the manifest from Camel with the ISO Schematron 2 distribution, not the file contents. The best way from here is to replace all of these with the files from the official distribution, which only have the MIT header. The Extract* files are a special case, not part of the distribution. Will dig deeper for authoritative source on those, I see a couple different versions floating around. Ill pull those out and put in the next PR, which makes more sense anyways. > I think you also mentioned some of this came from Apache Camel? The resources came from over there, but are going to be replaced with the standard distribution, nothing else remains a direct use. Overall I used their approach to guide the Scala implementation so wanted to give credit in readme, but everything was converted from Java to Scala and structurally changed. ### todo - [ ] replace other resources with ISO Sch distribution - [x] remove the Extract resources - [x] move to schematron package I can address this later today ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
