stevedlawrence commented on a change in pull request #452: URL: https://github.com/apache/incubator-daffodil/pull/452#discussion_r534228919
########## File path: daffodil-schematron/src/main/resources/iso-schematron-xslt2/ExtractSchFromRNG-2.xsl ########## @@ -0,0 +1,128 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<!-- + Stylesheet for extracting Schematron information from a RELAX-NG schema. + Based on the stylesheet for extracting Schematron information from W3C XML Schema. + + For usage details, see http://www.topologi.com/resources/schtrn_xsd_paper.html + + Created by Eddie Robertsson 2002/06/01 + Update for ISO Schematron using XSLT2 Rick Jelliffe 2010-04-14 + MIT licensed 2010-07-10 +--> + Review comment: Yeah, I'd say it's safest to just get things directly from the source. Following your link, it looks like https://github.com/schxslt/schxslt has become the latest for the XSLT schematron implementation. That doesn't mention anything about Apache license, but it's MIT which is fine as long as we update the various LICENSE files appropriately. Let me know if anything is unclear about where to make license updates. Though, looking some more at schxslt, it looks like there's also some java classes for it: https://github.com/schxslt/schxslt-java Which appears to be available on maven: https://search.maven.org/artifact/name.dmaus.schxslt/schxslt/1.5.2/jar That's also MIT licensed--it might be worth using that library to replace some the code in this commit. The less we have to maintain the better. A quick test shows it doesn't even pull in any dependencies I think, which is nice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
