stevedlawrence commented on a change in pull request #560:
URL: https://github.com/apache/daffodil/pull/560#discussion_r635424904
##########
File path:
daffodil-tdml-processor/src/main/scala/org/apache/daffodil/tdml/processor/DaffodilTDMLDFDLProcessor.scala
##########
@@ -159,14 +163,18 @@ final class TDMLDFDLProcessorFactory private (
override def getProcessor(
schemaSource: DaffodilSchemaSource,
useSerializedProcessor: Boolean,
- optRootName: Option[String] = None,
- optRootNamespace: Option[String] = None): TDML.CompileResult = {
+ optRootName: Option[String],
+ optRootNamespace: Option[String],
+ tunables: Map[String, String]): TDML.CompileResult = {
Review comment:
This is beyond the scope of this change, but will we even need the cache
at all? Could our test suites become something like this:
```scala
object TestFoo {
var runner: Runner = _
@BeforeClass def setup: Unit = { runner = Runner("foo.tdml") }
@AfterClass def tearDown: Unit = { runner = null }
}
```
This way we compile the TMDL files when JUnit is about to start the tests,
keep it around for the life of the suite, and then set it to null once all
tests are complete and let the garbage collector cleanup the runner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
