stevedlawrence commented on a change in pull request #560:
URL: https://github.com/apache/daffodil/pull/560#discussion_r636221312
##########
File path:
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -2402,8 +2402,9 @@ case class DFDLInfoset(di: Node, parent: Infoset) {
// The expected infoset is loaded using the normalizeCRLFtoLF mode (which
// is the default), so MS-DOS/Windows CRLFs in expected data XML files will
// have been converted into LF at this point.
- if (elem ne null)
+ if ((elem ne null) && elem.toString.contains("\r")) {
Assert.invariant(!elem.toString.contains("\r"))
Review comment:
Thoughts on if we want to keep this assertion? This is going to convert
every epected infoset to a string just to make sure there's no \r. Feels like
that might be somewhat expensive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
