mbeckerle commented on pull request #560: URL: https://github.com/apache/daffodil/pull/560#issuecomment-846251236
I just pushed fixes to all SL's comments. Barring major failure again on the CI tests, yes now would be good for a review. ________________________________ From: John Interrante ***@***.***> Sent: Friday, May 21, 2021 10:26 AM To: apache/daffodil ***@***.***> Cc: Beckerle, Mike ***@***.***>; Author ***@***.***> Subject: Re: [apache/daffodil] Verify that we get errors if the files contain a DOCTYPE (#560) Should I review now or wait? I wanted to wait until all the checks pass (which they do now), but your comments about some tests needing unexplainable changes makes me wonder if we should wait for more investigation. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/apache/daffodil/pull/560#issuecomment-845987642>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALUDA7EG42JQFOODSD3X5LTOZURLANCNFSM44ZBN3MA>. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
