stevedlawrence commented on a change in pull request #651:
URL: https://github.com/apache/daffodil/pull/651#discussion_r722337717
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/RawCommonRuntimeValuedPropertiesMixin.scala
##########
@@ -64,8 +64,6 @@ trait RawSequenceRuntimeValuedPropertiesMixin
trait RawLayeringRuntimeValuedPropertiesMixin
extends PropertyMixin {
- protected final lazy val optionLayerTransformRaw =
findPropertyOption("layerTransform", expressionAllowed = true)
- protected final lazy val layerTransformRaw =
requireProperty(optionLayerTransformRaw)
protected final lazy val optionLayerEncodingRaw =
findPropertyOption("layerEncoding", expressionAllowed = true)
Review comment:
> The dfdlx:layerEncoding property is only required if the layer
transform needs a
I think this is the thing that feels odd to me. We have a DFDL extension
property that is specific to text-related layers, some of which won't even use
it because they assume some encoding. For something that will soon allow
pluggable transforms, it seems we also need some way to have pluggable
properties specific to those transforms. To me encoding feels like it wants to
be that kind of property property because it only applies to certain
transforms. Maybe a key/value pair similar to dfdlx:runtimeProperties. The
other option is to just add new dfdlx:layer* properties everytime a layer needs
a property, but that doesn't scale well, and also makes thigns diffcult for
pluggable layers we don't/can't know about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
