mbeckerle commented on a change in pull request #651:
URL: https://github.com/apache/daffodil/pull/651#discussion_r723548374
##########
File path:
daffodil-core/src/test/scala/org/apache/daffodil/layers/TestLayers.scala
##########
@@ -304,7 +304,7 @@ a few lines of pointless text like this.""".replace("\r\n",
"\n").replace("\n",
*/
val ipsumLorem3 = s"""Lorem ipsum\r\n dolor sit amet,\r\nconsectetur
adipiscing elit"""
- val ipsumLorem3Unfolded = s"""Lorem ipsum dolor sit amet,"""
+ val ipsumLorem3Unfolded = s"""Lorem ipsum dolor sit amet,\nconsectetur
adipiscing elit"""
Review comment:
I am not at all sure why this had to be changed.
It looked to me like the test couldn't have worked right before, and now it
can, but clearly it used to pass.
##########
File path:
daffodil-core/src/test/scala/org/apache/daffodil/layers/TestLayers.scala
##########
@@ -317,7 +317,7 @@ a few lines of pointless text like this.""".replace("\r\n",
"\n").replace("\n",
val ipsumLorem4 = s"""Lorem ipsum dolor sit amet, consectetur adipiscing
elit, sed do eiusmod\r\n tempor incididunt\r\n"""
/////////////////////
123456789012345678901234567890123456789012345678901234567890123456789012 3
4567890123456789012345678901234567890123456789012345678901234567890
///////////////////// 1 2 3 4 5
6 7 8
- val ipsumLorem4Unfolded = s"""Lorem ipsum dolor sit amet, consectetur
adipiscing elit, sed do eiusmod tempor incididunt"""
+ val ipsumLorem4Unfolded = s"""Lorem ipsum dolor sit amet, consectetur
adipiscing elit, sed do eiusmod tempor incididunt\n"""
Review comment:
Same here. I am not sure why this change was needed.
Or more clearly - I am not sure why this test passed before, because this
added \n appears to be necessary to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
