mbeckerle commented on a change in pull request #651:
URL: https://github.com/apache/daffodil/pull/651#discussion_r723401771
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/RawCommonRuntimeValuedPropertiesMixin.scala
##########
@@ -64,8 +64,6 @@ trait RawSequenceRuntimeValuedPropertiesMixin
trait RawLayeringRuntimeValuedPropertiesMixin
extends PropertyMixin {
- protected final lazy val optionLayerTransformRaw =
findPropertyOption("layerTransform", expressionAllowed = true)
- protected final lazy val layerTransformRaw =
requireProperty(optionLayerTransformRaw)
protected final lazy val optionLayerEncodingRaw =
findPropertyOption("layerEncoding", expressionAllowed = true)
Review comment:
One can pass runtime-valued parameters to layers via DFDL variables.
So a properties-based mechanism would only be for providing
schema-compile-time parameters, if needed.
Right now nothing has been needed. The dfdlx:layerEncoding is needed for the
rare case where a transform's input character set is different from the
character set to be used when parsing the output of the layer. This is
certainly possible so is needed for complete composition properties.
I think we should add other compile-time properties to layers only if we
find they are needed due to real use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
