stevedlawrence commented on a change in pull request #681:
URL: https://github.com/apache/daffodil/pull/681#discussion_r754598833
##########
File path: .gitattributes
##########
@@ -13,4 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+# Convert to CRLF on Windows since tests expect System.lineSeparator
+* text=auto
Review comment:
I would prefer we apply this only to the runtime2 examples directory if
possible. I think those files are really the only ones where the new lines
*must* match the preferred OS line separator, since that's what the generator
outputs now. All other files should just follow the users `core.autocrlf`
settings that they think works best with their preferred development tools/OS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
