stevedlawrence commented on pull request #681: URL: https://github.com/apache/daffodil/pull/681#issuecomment-976697702
> I don't think anyone would deliberately hold back from committing the modified example files since they must have been making a change to the code generation backend anyway Maybe not deliberately, but I can definitely imagine accidentally leaving out files. Or someone using an IDE that doesn't use SBT (e.g. eclipse) and so the generator is never even run. If our goal is to have the examples always match what the generator will generate at each commit (which I like from a review perspective), adding a check somewhere to enforce that seems important, especially since there's not other way to know if it was updated or not. > Do note that incrementing the version number could have to commit the example files too depending on how sbt constructs the classpath. That's fine with me, it's pretty easy to manually bump version numbers in a couple files, and if we add a check, it will ensure that happens. Though, another option might be for the generator to generate something like `libcli/version.h` file which defines the `daffodil_program_version` variable. That way the version number is never in a file that is actually committed, so it doesn't matter if things can't find a version or if the version changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
