tuxji commented on a change in pull request #681:
URL: https://github.com/apache/daffodil/pull/681#discussion_r754605635
##########
File path: .gitattributes
##########
@@ -13,4 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+# Convert to CRLF on Windows since tests expect System.lineSeparator
+* text=auto
Review comment:
Even better, let's stop comparing the old example files to the new
example files and just update them unconditionally during "sbt compile" like we
update all the other automatically generated files. Then we can either apply
this setting only to the examples directory or remove both this setting and the
`replace("\n", System.lineSeparator)` calls from CodeGeneratorState's generate
methods. Either way will guarantee that updated example code files are checked
in with LFs, not CRLFs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
