stevedlawrence commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810167515
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
Should this be an actual icon file, or a standard square shape? Does
this icon show up some where in VS Code?
We do have an actual .ico file used for the Windows MSI that we could reuse
for this if an .ico file makes more sense than the logo:
https://raw.githubusercontent.com/apache/daffodil/main/daffodil-cli/src/windows/apache-daffodil.ico
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
